lkml.org 
[lkml]   [2018]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v5 05/12] PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is not set
    From
    Date


    On Wednesday 28 March 2018 05:20 PM, Niklas Cassel wrote:
    > Setting a BAR size > 4 GB is invalid if PCI_BASE_ADDRESS_MEM_TYPE_64
    > flag is not set.
    >
    > This sanity check is done in pci_epc_set_bar(), so that we don't need
    > to do this sanity check in all epc->ops->set_bar() implementations.
    >
    > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>

    Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
    > ---
    > drivers/pci/endpoint/pci-epc-core.c | 4 +++-
    > 1 file changed, 3 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
    > index 40eea20d21f9..8637822605ff 100644
    > --- a/drivers/pci/endpoint/pci-epc-core.c
    > +++ b/drivers/pci/endpoint/pci-epc-core.c
    > @@ -315,7 +315,9 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no,
    > (epf_bar->barno == BAR_5 &&
    > flags & PCI_BASE_ADDRESS_MEM_TYPE_64) ||
    > (flags & PCI_BASE_ADDRESS_SPACE_IO &&
    > - flags & PCI_BASE_ADDRESS_IO_MASK))
    > + flags & PCI_BASE_ADDRESS_IO_MASK) ||
    > + (upper_32_bits(epf_bar->size) &&
    > + !(flags & PCI_BASE_ADDRESS_MEM_TYPE_64)))
    > return -EINVAL;
    >
    > if (!epc->ops->set_bar)
    >

    \
     
     \ /
      Last update: 2018-03-29 11:43    [W:3.616 / U:24.880 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site