Messages in this thread | | | Date | Wed, 28 Mar 2018 16:20:29 -0700 | From | Davidlohr Bueso <> | Subject | Re: [REVIEW][PATCH 01/11] sem/security: Pass kern_ipc_perm not sem_array into the sem security hooks |
| |
On Fri, 23 Mar 2018, Casey Schaufler wrote:
>A kern_ipc_perm pointer is conventionally named isp in this code.
So the ideal name would be ipcp, used in core ipc, but I have no strong preference over isp, ipp or whatever other name is used in LSMs. The important thing is that kern_ipc_perm should not be called sma or any ipc specific name.
>How about instead:
Agreed.
> >-static int smack_sem_alloc_security(struct sem_array *sma) >+static int smack_sem_alloc_security(struct kern_ipc_perm *isp) > { >- struct kern_ipc_perm *isp = &sma->sem_perm; >
Thanks, Davidlohr
| |