lkml.org 
[lkml]   [2018]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH ghak32 V2 01/13] audit: add container id
    On Fri, 16 Mar 2018 05:00:28 -0400
    Richard Guy Briggs <rgb@redhat.com> wrote:

    > Implement the proc fs write to set the audit container ID of a process,
    > emitting an AUDIT_CONTAINER record to document the event.

    A little detail, but still...

    > +static int audit_set_containerid_perm(struct task_struct *task, u64 containerid)
    > +{
    > + struct task_struct *parent;
    > + u64 pcontainerid, ccontainerid;
    > +
    > + /* Don't allow to set our own containerid */
    > + if (current == task)
    > + return -EPERM;
    > + /* Don't allow the containerid to be unset */
    > + if (!cid_valid(containerid))
    > + return -EINVAL;

    I went looking for cid_valid(), but it turns out you don't add it until
    patch 5. That, I expect, will not be good for bisectability (or patch
    review).

    Thanks,

    jon

    \
     
     \ /
      Last update: 2018-03-28 20:40    [W:4.204 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site