Messages in this thread | | | Date | Wed, 28 Mar 2018 11:35:22 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] ftrace: fix task's invalid comm of <...> when big pid |
| |
On Wed, 28 Mar 2018 20:32:27 +0800 Wang Yu <yuwang@linux.alibaba.com> wrote:
> when pid is bigger than PID_MAX_DEFAULT, the comm of task > is <...>, it is better use pid_max to compare > > Signed-off-by: Wang Yu <yuwang@linux.alibaba.com> > --- > kernel/trace/trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > mode change 100644 => 100755 kernel/trace/trace.c > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > old mode 100644 > new mode 100755 > index 20a2300..0d4bc7a > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -1976,7 +1976,7 @@ static void __trace_find_cmdline(int pid, char comm[]) > return; > } > > - if (pid > PID_MAX_DEFAULT) { > + if (pid > pid_max) {
Thanks! this probably should go to stable.
-- Steve
> strcpy(comm, "<...>"); > return; > }
| |