lkml.org 
[lkml]   [2018]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 06/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file
    On Fri 23 Mar 03:18 PDT 2018, Sricharan R wrote:
    > +#include "qcom-ipq4019-ap.dk04.1.dtsi"
    > +
    > +/ {
    > + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK04.1-C1";
    > +

    If this is the board and qcom-ipq4019-ap.dk04.1.dtsi is the platform
    file then the compatible should be here and not there. Also qcom,ipq4019
    is not an awesome compatible for a board file.

    > + soc {
    > + dma@7984000 {
    > + status = "ok";
    > + };
    > +
    > + qpic-nand@79b0000 {
    > + pinctrl-0 = <&nand_pins>;
    > + pinctrl-names = "default";
    > + status = "ok";
    > + };

    nand_pins defines the muxing and is defined in the other dtsi. So please
    move these pinctrl-* properties to the dtsi.

    As long as the node is disabled the pinctrl state won't be applied
    anyways.


    If there are electrical properties that needs to be specified you can
    override the pinctrl state in the board specific file.

    Regards,
    Bjorn

    \
     
     \ /
      Last update: 2018-03-27 19:13    [W:7.069 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site