Messages in this thread | | | Date | Tue, 27 Mar 2018 23:51:19 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 4/6] rhashtable: allow a walk of the hash table without missing objects. |
| |
On Tue, Mar 27, 2018 at 10:33:04AM +1100, NeilBrown wrote: > > -int rhashtable_walk_start_check(struct rhashtable_iter *iter) > +int rhashtable_walk_start_continue(struct rhashtable_iter *iter, struct rhash_head *obj) > __acquires(RCU) > { > struct rhashtable *ht = iter->ht; > > rcu_read_lock(); > > + if (!obj || iter->p != obj) > + iter->p = NULL;
Why bother with this check at all? Couldn't we make it so that if you call continue then you continue with the cursor otherwise you set it to NULL as we currently do.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |