Messages in this thread | | | Date | Tue, 27 Mar 2018 08:31:10 -0700 (PDT) | Subject | Re: [tip:irq/core 12/13] drivers/irqchip/irq-vic.c:295:2: error: implicit declaration of function 'set_handle_irq'; did you mean 'vic_handle_irq'? | From | Palmer Dabbelt <> |
| |
On Mon, 26 Mar 2018 22:27:36 PDT (-0700), tglx@linutronix.de wrote: > On Mon, 26 Mar 2018, Palmer Dabbelt wrote: >> On Mon, 26 Mar 2018 01:07:54 PDT (-0700), Arnd Bergmann wrote: >> > On Tue, Mar 20, 2018 at 6:52 PM, Palmer Dabbelt <palmer@sifive.com> wrote: >> > > On Tue, 20 Mar 2018 00:53:21 PDT (-0700), tglx@linutronix.de wrote: >> > > > >> > > > On Tue, 20 Mar 2018, kbuild test robot wrote: >> > > > >> > > > > Hi Palmer, >> > > > > >> > > > > FYI, the error/warning still remains. >> > > > >> > > > >> > > > Zapped the commit as well... >> > > >> > > >> > > Sorry, I got the flu at ELC and have been offline for a bit. It looks >> > > like >> > > you've kept the IRQ and RISC-V patches, I'll fix up the others are >> > > re-submit >> > > them as a separate patch set. >> > >> > Not sure which patches are in flight at the moment. To get a clean build >> > on arm32 and arm64 randconfig kernels, I needed the fixup below >> > on top of linux-next (not meant to be applied like this, just for >> > reference). >> >> Thanks, I missed these during my original patch submission. I think the >> cleanest way to submit this is to spin a whole new patch set, including those >> that are already in tip. Would it be possible to just remove my IRQ cleanups >> from tip so I can try again? > > The commits in tip right now are: > > cc6c98485f8e ("RISC-V: Move to the new GENERIC_IRQ_MULTI_HANDLER handler") > caacdbf4aa56 ("genirq: Add CONFIG_GENERIC_IRQ_MULTI_HANDLER") > > I surely can revert them, but I don't see how they would break arm or > anything else.
If GENERIC_IRQ_MULTI_HANDLER is set via randconfig then set_handle_irq() is pulled in from the generic code, which conflicts with the definitions in arm, arm64, and openrisc. The RISC-V commit depends on the genirq one.
| |