Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 27 Mar 2018 10:51:45 +0200 | Subject | Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 |
| |
Hi Sebastian,
On Tue, Mar 27, 2018 at 10:41 AM, Sebastian Ott <sebott@linux.vnet.ibm.com> wrote: > On Tue, 27 Mar 2018, Geert Uytterhoeven wrote: >> On Tue, Mar 27, 2018 at 10:12 AM, Sebastian Ott >> <sebott@linux.vnet.ibm.com> wrote: >> > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma >> > allocations specifying __GFP_ZERO by silently removing that flag. >> >> How did it break? The flag is now always added. > > + flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM | __GFP_ZERO); > > I read that as a removal. But maybe I need more coffee..
Sorry, you're right.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |