Messages in this thread | | | From | Ilya Dryomov <> | Date | Mon, 26 Mar 2018 15:24:41 +0200 | Subject | Re: Re: Re: [PATCH 1/2] rbd: RBD_DEV_FLAG_THICK rbd_dev_flags bit |
| |
On Mon, Mar 26, 2018 at 2:31 PM, 亀井仁志 / KAMEI,HITOSHI <hitoshi.kamei.xm@hitachi.com> wrote: > Hi Ilya, > > I think your patch fully completes our purpose and I confirmed > that the kernel with the patch could work well by testing in my environment. > > I added the notrim option to rbd map command in accordance with > your kernel rbd driver patch, and I pushed the patch to GitHub > (https://github.com/hitoshikamei/ceph/tree/rbdmap-notrim).
Change the man page text to say
* notrim - Turn off discard and write zeroes offload support to avoid deprovisioning a fully provisioned image (since 4.17). When enabled, discard requests will fail with -EOPNOTSUPP, write zeroes requests will fall back to manually zeroing.
and merge it into the first patch.
> > So, could you please merge your patch to the kernel? If your patch is merged, > then my patch can work, so I will send the Pull Request.
https://github.com/ceph/ceph-client/commit/7ddd22f2dd1d82da9a4cc0c54dc10760a53964f0
You can open the PR right now, we just won't merge it until the kernel patch is in.
Thanks,
Ilya
| |