Messages in this thread | | | Date | Mon, 26 Mar 2018 12:01:14 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 4/7] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output. |
| |
Hi,
On Sun, Mar 25, 2018 at 04:09:13PM +0200, Paul Kocialkowski wrote: > Le mercredi 21 mars 2018 à 21:03 +0100, Giulio Benetti a écrit : > > The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting > > for the needed pins. > > > > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> > > --- > > arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi > > b/arch/arm/boot/dts/sun7i-a20.dtsi > > index efb5607..bfe6728 100644 > > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > > @@ -922,6 +922,14 @@ > > pins = "PI20", "PI21"; > > function = "uart7"; > > }; > > + > > + lcd0_rgb888_pins: lcd0-rgb888-pins { > > It would be more consistent with other pins definitions to have > underscores in both names and to indicate the index, such as: > lcd0_rgb888_pins: lcd0_rgb888_pins@0 {
Both your suggestions will generate DTC warnings, and we'd like to get rid of them eventually :)
> This way, other set of pins for LCD (PH0-PH27) can be declared as @1 > when they are needed in the future.
A better idea would be to call it lcd0-rgb888-pd-pins, and introduce the ph variant when it's done.
Maxime
-- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com [unhandled content-type:application/pgp-signature] | |