Messages in this thread | | | Subject | Re: [2/4] scsi: hpsa: Less function calls in hpsa_big_passthru_ioctl() after error detection | From | SF Markus Elfring <> | Date | Sat, 24 Mar 2018 10:01:07 +0100 |
| |
>> @@ -6501,14 +6501,16 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info >> *h, void __user *argp) >> cleanup0: >> cmd_free(h, c); >> cleanup1: >> - if (buff) { >> + { >> int i; >> >> for (i = 0; i < sg_used; i++) >> kfree(buff[i]); >> kfree(buff); >> } > > Thanks for looking at the hpsa driver. > > This HUNK ends up with an unnamed block.
Which identifier would you like to use there?
> I would prefer to not have it structured like this.
Would you like to show a source code layout alternative?
Regards, Markus
| |