| Subject | Re: [PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*. | From | Larry Finger <> | Date | Sat, 24 Mar 2018 16:23:02 -0500 |
| |
On 03/23/2018 11:10 PM, Quytelda Kahja wrote: > It is neater and more consistent with the rest of the document to use the > BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_* > bitmasks. In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP}, > bitshifting integers by 0 does nothing, so there is no reason to do it in > the code; replace these values with plain integers. > > Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
In the commit message for all of these, what is the "document" to which you refer?
I'm not quite sure why you split these changes into 3 parts, but I guess that is OK.
Larry
|