lkml.org 
[lkml]   [2018]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/44] perf annotate: Move annotation_options out of the TUI browser
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    This will be useful when making parts of the TUI browser generic enough
    to be used for a new stdio mode, available even when the TUI is not
    built in, for explicit user decision or when the necessary library devel
    files, for the slang library currently, are not available in the build
    system.

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: https://lkml.kernel.org/n/tip-45twzienhz7ypbad0sbvojku@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/ui/browsers/annotate.c | 10 +---------
    tools/perf/util/annotate.h | 10 ++++++++++
    2 files changed, 11 insertions(+), 9 deletions(-)

    diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
    index 618edf96353c..69ec968ac0be 100644
    --- a/tools/perf/ui/browsers/annotate.c
    +++ b/tools/perf/ui/browsers/annotate.c
    @@ -31,15 +31,7 @@ struct browser_line {
    int jump_sources;
    };

    -static struct annotate_browser_opt {
    - bool hide_src_code,
    - use_offset,
    - jump_arrows,
    - show_linenr,
    - show_nr_jumps,
    - show_nr_samples,
    - show_total_period;
    -} annotate_browser__opts = {
    +static struct annotation_options annotate_browser__opts = {
    .use_offset = true,
    .jump_arrows = true,
    };
    diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
    index 7e914e834101..e924033432a3 100644
    --- a/tools/perf/util/annotate.h
    +++ b/tools/perf/util/annotate.h
    @@ -58,6 +58,16 @@ bool ins__is_lock(const struct ins *ins);
    int ins__scnprintf(struct ins *ins, char *bf, size_t size, struct ins_operands *ops);
    bool ins__is_fused(struct arch *arch, const char *ins1, const char *ins2);

    +struct annotation_options {
    + bool hide_src_code,
    + use_offset,
    + jump_arrows,
    + show_linenr,
    + show_nr_jumps,
    + show_nr_samples,
    + show_total_period;
    +};
    +
    struct annotation;

    struct sym_hist_entry {
    --
    2.14.3
    \
     
     \ /
      Last update: 2018-03-24 21:15    [W:4.271 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site