Messages in this thread | | | Subject | Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper | From | Mike Looijmans <> | Date | Sat, 24 Mar 2018 17:03:29 +0100 |
| |
On 23-03-18 20:42, Andrew Lunn wrote: >> Indeed. I'll add my settings as an example. Where should I put this >> documentation, in the commit comment or somewhere in >> Documents/devicetree/bindings? > > Documention/devicetree/bindings/net/ethernet.txt
Ok
>> It's what I intended to do, but there were two problems with that: >> - of_get_mac_address() returns a pointer to constant data in memory, but the >> nvmem functions return an allocated memory object that must be freed after >> use. This changes the way the call is to be made. >> - The nvmem functions need the "struct device" pointer as well, while >> of_get_mac_address() only gets passed the DT node. > > Does of_nvmem_cell_get() help?
Yes, looking at the interface, it would.
-- Mike Looijmans
| |