Messages in this thread |  | | From | Ioana Ciornei <> | Subject | RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support | Date | Fri, 23 Mar 2018 15:56:24 +0000 |
| |
> > On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote: > > +#include "fsl-mc-private.h" > > + > > +#define FSL_MC_BUS_MAX_MINORS 1 > > As you only need/want one character device here, why not just use the misc > device api? It's much simpler, and handles all of the housekeeping for you > correctly. It also means I don't have to audit all of your chardev code to verify it > is correct :)
I have considered the misc device api but the fsl-mc bus, since it is a platform driver, is probing before the misc char driver.
Ioana
> > And it will save you lines-of-code, always a good thing. > > thanks, > > greg k-h
|  |