lkml.org 
[lkml]   [2018]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 53/84] PCI: rcar: Handle rcar_pcie_parse_request_of_pci_ranges() failures
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert+renesas@glider.be>


    [ Upstream commit 83c75ddd816e979802bd244ad494139f28152921 ]

    rcar_pcie_parse_request_of_pci_ranges() can fail and return an error
    code, but this is not checked nor handled.

    Fix this by adding the missing error handling.

    Fixes: 5d2917d469faab72 ("PCI: rcar: Convert to DT resource parsing API")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pci/host/pcie-rcar.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/pci/host/pcie-rcar.c
    +++ b/drivers/pci/host/pcie-rcar.c
    @@ -1123,7 +1123,9 @@ static int rcar_pcie_probe(struct platfo

    INIT_LIST_HEAD(&pcie->resources);

    - rcar_pcie_parse_request_of_pci_ranges(pcie);
    + err = rcar_pcie_parse_request_of_pci_ranges(pcie);
    + if (err)
    + goto err_free_bridge;

    err = rcar_pcie_get_resources(pcie);
    if (err < 0) {
    @@ -1178,6 +1180,7 @@ err_pm_disable:

    err_free_resource_list:
    pci_free_resource_list(&pcie->resources);
    +err_free_bridge:
    pci_free_host_bridge(bridge);

    return err;

    \
     
     \ /
      Last update: 2018-03-23 13:08    [W:4.160 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site