Messages in this thread | | | Subject | Re: [PATCH v5 2/3] RDMA/i40iw: Eliminate duplicate barriers on weakly-ordered archs | From | Sinan Kaya <> | Date | Fri, 23 Mar 2018 15:15:04 -0400 |
| |
On 3/22/2018 12:26 PM, Sinan Kaya wrote: > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > @@ -706,9 +706,11 @@ static void i40iw_sc_ccq_arm(struct i40iw_sc_cq *ccq) > wmb(); /* make sure shadow area is updated before arming */ > > if (ccq->dev->is_pf) > - i40iw_wr32(ccq->dev->hw, I40E_PFPE_CQARM, ccq->cq_uk.cq_id); > + i40iw_wr32_relaxed(ccq->dev->hw, I40E_PFPE_CQARM, > + ccq->cq_uk.cq_id); > else > - i40iw_wr32(ccq->dev->hw, I40E_VFPE_CQARM1, ccq->cq_uk.cq_id); > + i40iw_wr32_relaxed(ccq->dev->hw, I40E_VFPE_CQARM1, > + ccq->cq_uk.cq_id);
do we want an mmiowb() here?
> }
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |