lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
From
Date
On 03/22/2018 07:23 PM, Timur Tabi wrote:
>
> Also, you don't allocate chip->valid_mask anywhere.

So I see now where it's allocated, but something is fishy. I have three
TLMMs on my chip:

[ 67.107018] gpiochip_init_valid_mask:351 gpiochip->need_valid_mask=1
[ 67.153747] gpiochip_init_valid_mask:356 gpiochip->ngpio=72
[ 67.195324] gpiochip_init_valid_mask:361
gpiochip->valid_mask=0000000070b1a4b6
[ 68.532992] gpiochip_init_valid_mask:356 gpiochip->ngpio=44
[ 68.574496] gpiochip_init_valid_mask:361
gpiochip->valid_mask=000000002f33b8a3
[ 68.709378] msm_gpio_init_valid_mask:837 ret=44 max_gpios=44
chip->valid_mask=000000002f33b8a3
[ 69.726502] gpiochip_init_valid_mask:351 gpiochip->need_valid_mask=1
[ 69.772960] gpiochip_init_valid_mask:356 gpiochip->ngpio=54
[ 69.814084] gpiochip_init_valid_mask:361
gpiochip->valid_mask=000000001a53c932

Are these normal addresses for kcalloc() to return? They're not even
word-aligned.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2018-03-23 02:00    [W:0.105 / U:25.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site