lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested
From
Date
On 03/22/2018 07:16 PM, Timur Tabi wrote:
>
> This needs to be ret <= max_gpios, otherwise it will fail if every GPIO
> is available.
>
> And it should print an error message and return an error code if ret >
> max_gpios.

Also, you don't allocate chip->valid_mask anywhere.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2018-03-23 01:24    [W:0.093 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site