Messages in this thread | | | Subject | Re: [PATCH v3 3/3] pinctrl: qcom: Don't allow protected pins to be requested | From | Timur Tabi <> | Date | Thu, 22 Mar 2018 19:23:07 -0500 |
| |
On 03/22/2018 07:16 PM, Timur Tabi wrote: > > This needs to be ret <= max_gpios, otherwise it will fail if every GPIO > is available. > > And it should print an error message and return an error code if ret > > max_gpios.
Also, you don't allocate chip->valid_mask anywhere.
-- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |