lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/2] cpufreq: scpi: add thermal dependency
    Date
    On Wednesday, March 14, 2018 6:09:54 AM CET Viresh Kumar wrote:
    > On 13-03-18, 12:45, Arnd Bergmann wrote:
    > > A built-in scpi cpufreq driver cannot link against a modular
    > > thermal framework:
    > >
    > > drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_ready':
    > > scpi-cpufreq.c:(.text+0x4c): undefined reference to `of_cpufreq_cooling_register'
    > > drivers/cpufreq/scpi-cpufreq.o: In function `scpi_cpufreq_exit':
    > > scpi-cpufreq.c:(.text+0x9c): undefined reference to `cpufreq_cooling_unregister'
    > >
    > > This adds a Kconfig dependency that makes sure this configuration
    > > is not possible, while allowing all configurations that can work.
    > > Note that disabling CPU_THERMAL means we don't care about the
    > > THERMAL dependency.
    > >
    > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > > ---
    > > drivers/cpufreq/Kconfig.arm | 1 +
    > > 1 file changed, 1 insertion(+)
    > >
    > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
    > > index 9bbb5b39d18a..d9457d1e535c 100644
    > > --- a/drivers/cpufreq/Kconfig.arm
    > > +++ b/drivers/cpufreq/Kconfig.arm
    > > @@ -45,6 +45,7 @@ config ARM_DT_BL_CPUFREQ
    > > config ARM_SCPI_CPUFREQ
    > > tristate "SCPI based CPUfreq driver"
    > > depends on ARM_SCPI_PROTOCOL && COMMON_CLK_SCPI
    > > + depends on !CPU_THERMAL || THERMAL
    > > help
    > > This adds the CPUfreq driver support for ARM platforms using SCPI
    > > protocol for CPU power management.
    >
    > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

    Applied, thanks!

    \
     
     \ /
      Last update: 2018-03-23 00:28    [W:2.182 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site