lkml.org 
[lkml]   [2018]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses
On Thu, Mar 22, 2018 at 01:37:45PM +0900, y.k.oh wrote:
>
>
> On 03/14/2018 10:58 PM, Greg KH wrote:
> > On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote:
> >> Cleanup checkpatch error:
> >> ERROR: Macros with complex values should be enclosed in parentheses
> >>
> >> Signed-off-by: YOUNGKEUN OH <y.k.oh@samsung.com>
> >> ---
> >> drivers/tty/serial/samsung.c | 16 ++++++++--------
> >> 1 file changed, 8 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> >> index 3f2f8c1..da9bddb1 100644
> >> --- a/drivers/tty/serial/samsung.c
> >> +++ b/drivers/tty/serial/samsung.c
> >> @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void)
> >> }
> >> console_initcall(s3c24xx_serial_console_init);
> >>
> >> -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console
> >> +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console)
> >
> > That's not a complex macro!
> >
> > Please use checkpatch as a hint, not the "truth".
> >
> > thanks,
> >
> > greg k-h
> >
> Dear Greg.
>
> Yes! Of course that's not a pretty complex macro. However, I think it is
> important to make a small effort to modify the minimum standard,
> Checkpatch ERROR, to ensure consistency in the Linux code.
> Starting with this Checkpatch error of samsung.c, I would like to start
> my efforts on contribution from a small point. Please review it again.

Why would I review something again that is not correct?

If you wish to start out in kernel development, please start in
drivers/staging/*/TODO, not in "core" kernel code. That is what the
drivers/staging/ code is there for.

good luck!

greg k-h

\
 
 \ /
  Last update: 2018-03-22 09:46    [W:0.041 / U:2.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site