Messages in this thread | | | Date | Thu, 22 Mar 2018 14:53:06 -0400 (EDT) | Subject | Re: [PATCH][next] gre: fix TUNNEL_SEQ bit check on sequence numbering | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Wed, 21 Mar 2018 19:34:58 +0000
> From: Colin Ian King <colin.king@canonical.com> > > The current logic of flags | TUNNEL_SEQ is always non-zero and hence > sequence numbers are always incremented no matter the setting of the > TUNNEL_SEQ bit. Fix this by using & instead of |. > > Detected by CoverityScan, CID#1466039 ("Operands don't affect result") > > Fixes: 77a5196a804e ("gre: add sequence number for collect md mode.") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks Colin.
| |