Messages in this thread | | | Date | Thu, 22 Mar 2018 17:11:30 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 06/10] x86/microcode/AMD: Check patch size in verify_and_add_patch() |
| |
On Fri, Mar 16, 2018 at 12:08:17AM +0100, Maciej S. Szmigiero wrote: > @@ -505,7 +505,7 @@ static unsigned int verify_patch_size(u8 family, u32 patch_size, > break; > } > > - if (patch_size > min_t(u32, size, max_size)) { > + if (patch_size > min_t(size_t, size, max_size)) {
So I don't like this conversion to 8-byte-width size_t's. It is not necessary. I'm pretty sure we can do fine with signed and unsigned ints.
For example, you can convert the size to signed int (if it hasn't been converted yet) and check for < 0 and stop further processing. And so on...
Thx.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. Srsly.
| |