Messages in this thread | | | From | Ulf Hansson <> | Date | Thu, 22 Mar 2018 10:28:57 +0100 | Subject | Re: [PATCH 1/7] PM / OPP: Implement dev_pm_opp_of_add_table_indexed() |
| |
On 22 December 2017 at 08:26, Viresh Kumar <viresh.kumar@linaro.org> wrote: > The "operating-points-v2" property can contain a list of phandles now, > specifically for the power domain providers that provide multiple > domains. > > Add support to parse that. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards Uffe
> --- > drivers/opp/of.c | 50 +++++++++++++++++++++++++++++++++++++++++--------- > include/linux/pm_opp.h | 6 ++++++ > 2 files changed, 47 insertions(+), 9 deletions(-) > > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > index cb716aa2f44b..22c9bd191f62 100644 > --- a/drivers/opp/of.c > +++ b/drivers/opp/of.c > @@ -250,20 +250,17 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_of_remove_table); > > /* Returns opp descriptor node for a device node, caller must > * do of_node_put() */ > -static struct device_node *_opp_of_get_opp_desc_node(struct device_node *np) > +static struct device_node *_opp_of_get_opp_desc_node(struct device_node *np, > + int index) > { > - /* > - * There should be only ONE phandle present in "operating-points-v2" > - * property. > - */ > - > - return of_parse_phandle(np, "operating-points-v2", 0); > + /* "operating-points-v2" can be an array for power domain providers */ > + return of_parse_phandle(np, "operating-points-v2", index); > } > > /* Returns opp descriptor node for a device, caller must do of_node_put() */ > struct device_node *dev_pm_opp_of_get_opp_desc_node(struct device *dev) > { > - return _opp_of_get_opp_desc_node(dev->of_node); > + return _opp_of_get_opp_desc_node(dev->of_node, 0); > } > EXPORT_SYMBOL_GPL(dev_pm_opp_of_get_opp_desc_node); > > @@ -509,6 +506,41 @@ int dev_pm_opp_of_add_table(struct device *dev) > } > EXPORT_SYMBOL_GPL(dev_pm_opp_of_add_table); > > +/** > + * dev_pm_opp_of_add_table_indexed() - Initialize indexed opp table from device tree > + * @dev: device pointer used to lookup OPP table. > + * @index: Index number. > + * > + * Register the initial OPP table with the OPP library for given device only > + * using the "operating-points-v2" property. > + * > + * Return: > + * 0 On success OR > + * Duplicate OPPs (both freq and volt are same) and opp->available > + * -EEXIST Freq are same and volt are different OR > + * Duplicate OPPs (both freq and volt are same) and !opp->available > + * -ENOMEM Memory allocation failure > + * -ENODEV when 'operating-points' property is not found or is invalid data > + * in device node. > + * -ENODATA when empty 'operating-points' property is found > + * -EINVAL when invalid entries are found in opp-v2 table > + */ > +int dev_pm_opp_of_add_table_indexed(struct device *dev, int index) > +{ > + struct device_node *opp_np; > + int ret; > + > + opp_np = _opp_of_get_opp_desc_node(dev->of_node, index); > + if (!opp_np) > + return -ENODEV; > + > + ret = _of_add_opp_table_v2(dev, opp_np); > + of_node_put(opp_np); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(dev_pm_opp_of_add_table_indexed); > + > /* CPU device specific helpers */ > > /** > @@ -613,7 +645,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev, > } > > /* Get OPP descriptor node */ > - tmp_np = _opp_of_get_opp_desc_node(cpu_np); > + tmp_np = _opp_of_get_opp_desc_node(cpu_np, 0); > of_node_put(cpu_np); > if (!tmp_np) { > pr_err("%pOF: Couldn't find opp node\n", cpu_np); > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index 6c2d2e88f066..f042fdeaaa3c 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -303,6 +303,7 @@ static inline void dev_pm_opp_cpumask_remove_table(const struct cpumask *cpumask > > #if defined(CONFIG_PM_OPP) && defined(CONFIG_OF) > int dev_pm_opp_of_add_table(struct device *dev); > +int dev_pm_opp_of_add_table_indexed(struct device *dev, int index); > void dev_pm_opp_of_remove_table(struct device *dev); > int dev_pm_opp_of_cpumask_add_table(const struct cpumask *cpumask); > void dev_pm_opp_of_cpumask_remove_table(const struct cpumask *cpumask); > @@ -314,6 +315,11 @@ static inline int dev_pm_opp_of_add_table(struct device *dev) > return -ENOTSUPP; > } > > +static inline int dev_pm_opp_of_add_table_indexed(struct device *dev, int index) > +{ > + return -ENOTSUPP; > +} > + > static inline void dev_pm_opp_of_remove_table(struct device *dev) > { > } > -- > 2.15.0.194.g9af6a3dea062 >
| |