Messages in this thread | | | Subject | Re: [PATCH 10/15] mm/hmm: do not differentiate between empty entry or missing directory v2 | From | John Hubbard <> | Date | Wed, 21 Mar 2018 16:16:50 -0700 |
| |
On 03/21/2018 07:48 AM, Jerome Glisse wrote: > On Tue, Mar 20, 2018 at 10:24:34PM -0700, John Hubbard wrote: >> On 03/19/2018 07:00 PM, jglisse@redhat.com wrote: >>> From: Jérôme Glisse <jglisse@redhat.com> >>>
<snip>
>> >> <snip> >> >>> @@ -438,7 +423,7 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, >>> pfns[i] = 0; >>> >>> if (pte_none(pte)) { >>> - pfns[i] = HMM_PFN_EMPTY; >>> + pfns[i] = 0; >> >> This works, but why not keep HMM_PFN_EMPTY, and just define it as zero? >> Symbols are better than raw numbers here. >> > > The last patch do that so i don't think it is worth respinning > just to make this intermediate state prettier. >
Yes, you're right, of course. And, no other problems found, so:
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks, -- John Hubbard NVIDIA
| |