lkml.org 
[lkml]   [2018]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] aio: remove an outdated comment in aio_complete
On Wed, Mar 21, 2018 at 10:14:20AM +0100, Greg KH wrote:
> > diff --git a/fs/aio.c b/fs/aio.c
> > index 03d59593912d..41fc8ce6bc7f 100644
> > --- a/fs/aio.c
> > +++ b/fs/aio.c
> > @@ -1088,6 +1088,8 @@ static void aio_complete(struct kiocb *kiocb, long res, long res2)
> > unsigned tail, pos, head;
> > unsigned long flags;
> >
> > + BUG_ON(is_sync_kiocb(kiocb));
>
> Is this BUG_ON even needed anymore? Does it ever trip in any "regular"
> use, or is it only there for when a developer does something dumb? If
> "dumb", then we should keep it, otherwise we might be able to just drop
> it.

Probably not event needed anymore. is_sync_kiocb checks that
ki_complete is non-NULL, and aio_complete is static in aio.c now, so
it is almost impossibly to hit.

\
 
 \ /
  Last update: 2018-03-21 10:18    [W:0.309 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site