Messages in this thread | | | Date | Tue, 20 Mar 2018 14:57:31 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup |
| |
On Tue, Mar 20, 2018 at 10:48:40PM +0100, Peter Rosin wrote: > On 2018-03-20 14:20, Guenter Roeck wrote: > > On 03/20/2018 02:31 AM, Peter Rosin wrote: > >> +static int pca9541_mybus(int ctl) > > > > bool ? > > > >> +{ > >> + if (!(ctl & PCA9541_MYBUS)) > >> + return 1; > > > > true ? > > > >> + return (ctl & PCA9541_MYBUS) == PCA9541_MYBUS; > >> +} > >> + > >> +static int pca9541_busoff(int ctl) > > > > bool ? > > > >> +{ > >> + if (!(ctl & PCA9541_BUSON)) > >> + return 1; > > > > true ? > > bool? true? Isn't that C++? Sigh, but you're right, and old habits > die hard... > > Would it be ok to add your reviewed-by tag as I fix that? > Sure.
Guenter
> Cheers, > Peter
| |