Messages in this thread | | | Subject | Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup | From | Peter Rosin <> | Date | Tue, 20 Mar 2018 22:48:40 +0100 |
| |
On 2018-03-20 14:20, Guenter Roeck wrote: > On 03/20/2018 02:31 AM, Peter Rosin wrote: >> +static int pca9541_mybus(int ctl) > > bool ? > >> +{ >> + if (!(ctl & PCA9541_MYBUS)) >> + return 1; > > true ? > >> + return (ctl & PCA9541_MYBUS) == PCA9541_MYBUS; >> +} >> + >> +static int pca9541_busoff(int ctl) > > bool ? > >> +{ >> + if (!(ctl & PCA9541_BUSON)) >> + return 1; > > true ?
bool? true? Isn't that C++? Sigh, but you're right, and old habits die hard...
Would it be ok to add your reviewed-by tag as I fix that?
Cheers, Peter
| |