lkml.org 
[lkml]   [2018]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v8 18/42] clk: davinci: New driver for TI DA8XX CFGCHIP clocks
    From
    Date
    On 03/20/2018 11:54 AM, Stephen Boyd wrote:
    > Quoting David Lechner (2018-03-15 19:52:34)
    >> +
    >> +typedef int (*da8xx_cfgchip_init)(struct device *dev, void __iomem *base);
    >
    > Should be struct regmap *regmap?

    Yes. It looks like this was copied and pasted from one of the other drivers.

    Thank you for fixing it.

    >
    > I've squashed this in.
    >
    > diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c
    > index 858d3786b27b..c971111d2601 100644
    > --- a/drivers/clk/davinci/da8xx-cfgchip.c
    > +++ b/drivers/clk/davinci/da8xx-cfgchip.c
    > @@ -736,7 +736,7 @@ static const struct platform_device_id da8xx_cfgchip_id_table[] = {
    > { }
    > };
    >
    > -typedef int (*da8xx_cfgchip_init)(struct device *dev, void __iomem *base);
    > +typedef int (*da8xx_cfgchip_init)(struct device *dev, struct regmap *regmap);
    >
    > static int da8xx_cfgchip_probe(struct platform_device *pdev)
    > {
    >

    \
     
     \ /
      Last update: 2018-03-20 17:58    [W:4.159 / U:1.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site