lkml.org 
[lkml]   [2018]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] i2c: mux: pca9541: use the BIT macro
From
Date
On 03/20/2018 02:31 AM, Peter Rosin wrote:
> Because it looks nice!
>
> Signed-off-by: Peter Rosin <peda@axentia.se>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> drivers/i2c/muxes/i2c-mux-pca9541.c | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index 6a39adaf433f..ad168125d23d 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -16,6 +16,7 @@
> * warranty of any kind, whether express or implied.
> */
>
> +#include <linux/bitops.h>
> #include <linux/delay.h>
> #include <linux/device.h>
> #include <linux/i2c.h>
> @@ -43,20 +44,20 @@
> #define PCA9541_CONTROL 0x01
> #define PCA9541_ISTAT 0x02
>
> -#define PCA9541_CTL_MYBUS (1 << 0)
> -#define PCA9541_CTL_NMYBUS (1 << 1)
> -#define PCA9541_CTL_BUSON (1 << 2)
> -#define PCA9541_CTL_NBUSON (1 << 3)
> -#define PCA9541_CTL_BUSINIT (1 << 4)
> -#define PCA9541_CTL_TESTON (1 << 6)
> -#define PCA9541_CTL_NTESTON (1 << 7)
> -
> -#define PCA9541_ISTAT_INTIN (1 << 0)
> -#define PCA9541_ISTAT_BUSINIT (1 << 1)
> -#define PCA9541_ISTAT_BUSOK (1 << 2)
> -#define PCA9541_ISTAT_BUSLOST (1 << 3)
> -#define PCA9541_ISTAT_MYTEST (1 << 6)
> -#define PCA9541_ISTAT_NMYTEST (1 << 7)
> +#define PCA9541_CTL_MYBUS BIT(0)
> +#define PCA9541_CTL_NMYBUS BIT(1)
> +#define PCA9541_CTL_BUSON BIT(2)
> +#define PCA9541_CTL_NBUSON BIT(3)
> +#define PCA9541_CTL_BUSINIT BIT(4)
> +#define PCA9541_CTL_TESTON BIT(6)
> +#define PCA9541_CTL_NTESTON BIT(7)
> +
> +#define PCA9541_ISTAT_INTIN BIT(0)
> +#define PCA9541_ISTAT_BUSINIT BIT(1)
> +#define PCA9541_ISTAT_BUSOK BIT(2)
> +#define PCA9541_ISTAT_BUSLOST BIT(3)
> +#define PCA9541_ISTAT_MYTEST BIT(6)
> +#define PCA9541_ISTAT_NMYTEST BIT(7)
>
> #define BUSON (PCA9541_CTL_BUSON | PCA9541_CTL_NBUSON)
> #define MYBUS (PCA9541_CTL_MYBUS | PCA9541_CTL_NMYBUS)
>

\
 
 \ /
  Last update: 2018-03-20 14:19    [W:0.127 / U:1.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site