Messages in this thread | | | Subject | Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function | From | Giulio Benetti <> | Date | Fri, 2 Mar 2018 17:50:24 +0100 |
| |
Hi,
Il 02/03/2018 15:37, Maxime Ripard ha scritto: > On Fri, Mar 02, 2018 at 12:42:14PM +0100, Giulio Benetti wrote: >> Hi, >> >> Il 01/03/2018 10:57, Maxime Ripard ha scritto: >>> On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote: >>>> static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = { >>>> .get_modes = sun4i_lvds_get_modes, >>>> + .mode_valid = sun4i_lvds_mode_valid, >>>> }; >>> >>> This should be on the encoder, not the connector. >> >> I've seen it is bound to connector in rgb and to encoder in hdmi. >> Is it correct rgb mode_valid under connector funcs? >> Otherwise I send a patch also for that one. > > This would need to be fixed as well. Bridges attach to encoder, not > connectors, so if you ever have a bridge connected to the RGB output > (like on the A13-Olinuxino), mode_valid isn't called at the moment.
Ok, I will do the same for rgb and submit a patchset, need some time to test both lvds and rgb.
-- Giulio Benetti CTO
MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
| |