lkml.org 
[lkml]   [2018]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 51/56] xen/gntdev: Fix off-by-one error when unmapping with holes
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ross Lagerwall <ross.lagerwall@citrix.com>


    [ Upstream commit 951a010233625b77cde3430b4b8785a9a22968d1 ]

    If the requested range has a hole, the calculation of the number of
    pages to unmap is off by one. Fix it.

    Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/xen/gntdev.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/xen/gntdev.c
    +++ b/drivers/xen/gntdev.c
    @@ -378,10 +378,8 @@ static int unmap_grant_pages(struct gran
    }
    range = 0;
    while (range < pages) {
    - if (map->unmap_ops[offset+range].handle == -1) {
    - range--;
    + if (map->unmap_ops[offset+range].handle == -1)
    break;
    - }
    range++;
    }
    err = __unmap_grant_pages(map, offset, range);

    \
     
     \ /
      Last update: 2018-03-02 11:08    [W:4.119 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site