lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.4 116/167] mISDN: Fix a sleep-in-atomic bug
    Date
    From: Jia-Ju Bai <baijiaju1990@163.com>

    [ Upstream commit 93818da5eed63fbc17b64080406ea53b86b23309 ]

    The driver may sleep under a read spin lock, and the function call path is:
    send_socklist (acquire the lock by read_lock)
    skb_copy(GFP_KERNEL) --> may sleep

    To fix it, the "GFP_KERNEL" is replaced with "GFP_ATOMIC".

    Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/isdn/mISDN/stack.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/isdn/mISDN/stack.c b/drivers/isdn/mISDN/stack.c
    index 9cb4b621fbc3..b92a19a594a1 100644
    --- a/drivers/isdn/mISDN/stack.c
    +++ b/drivers/isdn/mISDN/stack.c
    @@ -72,7 +72,7 @@ send_socklist(struct mISDN_sock_list *sl, struct sk_buff *skb)
    if (sk->sk_state != MISDN_BOUND)
    continue;
    if (!cskb)
    - cskb = skb_copy(skb, GFP_KERNEL);
    + cskb = skb_copy(skb, GFP_ATOMIC);
    if (!cskb) {
    printk(KERN_WARNING "%s no skb\n", __func__);
    break;
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-19 17:13    [W:2.388 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site