lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4] thermal: Add cooling device's statistics in sysfs
On 14-03-18, 13:44, Viresh Kumar wrote:
> I got those warnings as well, and I quietly ignored them :)
>
> I ignored the renaming part for the sake of consistency. The other existing
> routines for similar purpose are named as:
>
> thermal_cooling_device_type_show
> thermal_cooling_device_max_state_show
> thermal_cooling_device_cur_state_show
> thermal_cooling_device_cur_state_store
>
> for me it made more sense to follow that naming convention. And I didn't use the
> _RO and _WO variants for the same reason.
>
> Now here is what I propose now:
>
> - You apply this patch as-is and ignore the warning.
>
> - I will send few patches on top of that to do:
> - renaming of all such routines to shorter versions.
> - Use the _RO or _WO variants of the macro everywhere.
>
> What do you say ?

@Zhang: Can you please share the way you want this to get merged ? And if the
above is fine with you ?

--
viresh

\
 
 \ /
  Last update: 2018-03-20 02:38    [W:0.055 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site