Messages in this thread | | | Subject | Re: [PATCH 11/14] mm/hmm: move hmm_pfns_clear() closer to where it is use | From | John Hubbard <> | Date | Mon, 19 Mar 2018 16:12:10 -0700 |
| |
On 03/16/2018 01:35 PM, jglisse@redhat.com wrote: > From: Jérôme Glisse <jglisse@redhat.com> > > Move hmm_pfns_clear() closer to where it is use to make it clear it > is not use by page table walkers. > > Signed-off-by: Jérôme Glisse <jglisse@redhat.com> > Cc: Evgeny Baskakov <ebaskakov@nvidia.com> > Cc: Ralph Campbell <rcampbell@nvidia.com> > Cc: Mark Hairgrove <mhairgrove@nvidia.com> > Cc: John Hubbard <jhubbard@nvidia.com> > --- > mm/hmm.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> > diff --git a/mm/hmm.c b/mm/hmm.c > index 857eec622c98..3a708f500b80 100644 > --- a/mm/hmm.c > +++ b/mm/hmm.c > @@ -297,14 +297,6 @@ static int hmm_pfns_bad(unsigned long addr, > return 0; > } > > -static void hmm_pfns_clear(uint64_t *pfns, > - unsigned long addr, > - unsigned long end) > -{ > - for (; addr < end; addr += PAGE_SIZE, pfns++) > - *pfns = 0; > -} > - > /* > * hmm_vma_walk_hole() - handle a range back by no pmd or no pte > * @start: range virtual start address (inclusive) > @@ -463,6 +455,14 @@ static int hmm_vma_walk_pmd(pmd_t *pmdp, > return 0; > } > > +static void hmm_pfns_clear(uint64_t *pfns, > + unsigned long addr, > + unsigned long end) > +{ > + for (; addr < end; addr += PAGE_SIZE, pfns++) > + *pfns = 0; > +} > +
Yep, identical, so no functional changes.
> static void hmm_pfns_special(struct hmm_range *range) > { > unsigned long addr = range->start, i = 0;
thanks, -- John Hubbard NVIDIA
| |