lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 076/281] sh_eth: Use platform device for printing before register_netdev()
    Date
    From: Geert Uytterhoeven <geert+renesas@glider.be>

    [ Upstream commit 5f5c5449acad0cd3322e53e1ac68c044483b0aa5 ]

    The MDIO initialization failure message is printed using the network
    device, before it has been registered, leading to:

    (null): failed to initialise MDIO

    Use the platform device instead to fix this:

    sh-eth ee700000.ethernet: failed to initialise MDIO

    Fixes: daacf03f0bbfefee ("sh_eth: Register MDIO bus before registering the network device")
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/ethernet/renesas/sh_eth.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
    index b6816ae00b7a..c8fd99b3ca29 100644
    --- a/drivers/net/ethernet/renesas/sh_eth.c
    +++ b/drivers/net/ethernet/renesas/sh_eth.c
    @@ -3133,7 +3133,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
    /* MDIO bus init */
    ret = sh_mdio_init(mdp, pd);
    if (ret) {
    - dev_err(&ndev->dev, "failed to initialise MDIO\n");
    + dev_err(&pdev->dev, "failed to initialise MDIO\n");
    goto out_release;
    }

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-19 22:26    [W:2.667 / U:0.308 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site