lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.9 077/281] mlxsw: spectrum: Avoid possible NULL pointer dereference
    Date
    From: Ido Schimmel <idosch@mellanox.com>

    [ Upstream commit c0e01eac7ada785fdeaea1ae5476ec1cf3b00374 ]

    In case we got an FDB notification for a port that doesn't exist we
    execute an FDB entry delete to prevent it from re-appearing the next
    time we poll for notifications.

    If the operation failed we would trigger a NULL pointer dereference as
    'mlxsw_sp_port' is NULL.

    Fix it by reporting the error using the underlying bus device instead.

    Fixes: 12f1501e7511 ("mlxsw: spectrum: remove FDB entry in case we get unknown object notification")
    Signed-off-by: Ido Schimmel <idosch@mellanox.com>
    Signed-off-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
    index bea9ae31a769..60e1edcbe573 100644
    --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
    +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
    @@ -1448,8 +1448,7 @@ static void mlxsw_sp_fdb_notify_mac_process(struct mlxsw_sp *mlxsw_sp,
    err = mlxsw_sp_port_fdb_uc_op(mlxsw_sp, local_port, mac, fid,
    adding, true);
    if (err) {
    - if (net_ratelimit())
    - netdev_err(mlxsw_sp_port->dev, "Failed to set FDB entry\n");
    + dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to set FDB entry\n");
    return;
    }

    @@ -1509,8 +1508,7 @@ static void mlxsw_sp_fdb_notify_mac_lag_process(struct mlxsw_sp *mlxsw_sp,
    err = mlxsw_sp_port_fdb_uc_lag_op(mlxsw_sp, lag_id, mac, fid, lag_vid,
    adding, true);
    if (err) {
    - if (net_ratelimit())
    - netdev_err(mlxsw_sp_port->dev, "Failed to set FDB entry\n");
    + dev_err_ratelimited(mlxsw_sp->bus_info->dev, "Failed to set FDB entry\n");
    return;
    }

    --
    2.14.1
    \
     
     \ /
      Last update: 2018-03-19 22:25    [W:3.337 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site