Messages in this thread | | | Date | Mon, 19 Mar 2018 23:24:36 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm: allow TCPA log area to be empty |
| |
On Sun, Mar 18, 2018 at 08:13:23PM -0600, Jason Gunthorpe wrote: > On Fri, Mar 16, 2018 at 02:55:25PM +0200, Jarkko Sakkinen wrote: > > On Mon, Mar 12, 2018 at 09:02:32AM -0600, Jason Gunthorpe wrote: > > > On Sat, Mar 10, 2018 at 06:16:37PM +0200, Jarkko Sakkinen wrote: > > > > TCPA log are can be empty when the TPM is disabled. This commit changes the > > > > behavior of tpm_read_log_acpi() to return successfully in this case. > > > > > > The commit should explain why we'd want this.. > > > > > > eg Why does it matter to create the extra sysfs files to report an empty > > > log? > > > > > > Jason > > > > The initialization of the driver will fail otherwise. Not sure if I > > understand your question. > > Well, I mean in the sense of what is broken and why is this the right > fix. Why not return -ENODEV?
Well, because then the device initialization would fail.
Just noticed that this is missing:
Reported-by: Sahil Rihan <srihan@fb.com>
Sahil, would you care to try if this fixes the issue that you are having or not?
/Jarkko
| |