lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 15/68] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Janusz Krzysztofik <jmkrzyszt@gmail.com>


    [ Upstream commit 54449af0e0b2ea43a8166611c95b730c850c3184 ]

    After changes to v4l2_clk API introduced in v4.1 by commits a37462b919
    '[media] V4L: remove clock name from v4l2_clk API' and 4f528afcfb
    '[media] V4L: add CCF support to the v4l2_clk API', ov6650 sensor
    stopped responding because v4l2_clk_get(), still called with
    depreciated V4L2 clock name "mclk", started to return respective CCF
    clock instead of the V4l2 one registered by soc_camera. Fix it by
    calling v4l2_clk_get() with NULL clock name.

    Created and tested on Amstrad Delta against Linux-4.7-rc3 with
    omap1_camera fixes.

    Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
    Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/media/i2c/soc_camera/ov6650.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/i2c/soc_camera/ov6650.c
    +++ b/drivers/media/i2c/soc_camera/ov6650.c
    @@ -1016,7 +1016,7 @@ static int ov6650_probe(struct i2c_clien
    priv->code = V4L2_MBUS_FMT_YUYV8_2X8;
    priv->colorspace = V4L2_COLORSPACE_JPEG;

    - priv->clk = v4l2_clk_get(&client->dev, "mclk");
    + priv->clk = v4l2_clk_get(&client->dev, NULL);
    if (IS_ERR(priv->clk)) {
    ret = PTR_ERR(priv->clk);
    goto eclkget;

    \
     
     \ /
      Last update: 2018-03-19 21:51    [W:4.342 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site