Messages in this thread | | | Date | Mon, 19 Mar 2018 19:09:50 +0100 | From | Paolo Pisati <> | Subject | Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support |
| |
On Fri, Mar 16, 2018 at 09:26:54AM -0700, Moritz Fischer wrote: > > > > +static enum fpga_mgr_states machxo2_spi_state(struct fpga_manager *mgr) > > +{ > > + return FPGA_MGR_STATE_UNKNOWN; > > +} > > To understand this correctly: Further up you have a way to determine the > state you're in, but then you only use that for debug printout, while > here where you should provide the status you say FPGA_MGR_STATE_UNKNOWN? > > Am I missing something here?
This is more of a generic function ('What's the state of the FPGA now?') while dump_status_reg() is invoked after a specific SPI command is sent to the FPGA to keep track of the status of the chip and check that it adhere to the state machine.
I'll send a v7. -- bye, p.
| |