lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 004/134] staging: wilc1000: add check for kmalloc allocation failure.
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>


    [ Upstream commit 6cc0c259d034c6ab48f4e12f505213988e73d380 ]

    Add a sanity check that wid.val has been allocated, fixes a null
    pointer deference on stamac when calling ether_add_copy.

    Detected by CoverityScan, CID#1369537 ("Dereference null return value")

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/staging/wilc1000/host_interface.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/staging/wilc1000/host_interface.c
    +++ b/drivers/staging/wilc1000/host_interface.c
    @@ -2179,6 +2179,8 @@ static s32 Handle_Get_InActiveTime(struc
    wid.type = WID_STR;
    wid.size = ETH_ALEN;
    wid.val = kmalloc(wid.size, GFP_KERNEL);
    + if (!wid.val)
    + return -ENOMEM;

    stamac = wid.val;
    memcpy(stamac, strHostIfStaInactiveT->mac, ETH_ALEN);

    \
     
     \ /
      Last update: 2018-03-19 21:28    [W:4.082 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site