lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 081/134] HID: elo: clear BTN_LEFT mapping
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiri Kosina <jkosina@suse.cz>


    [ Upstream commit 9abd04af951e5734c9d5cfee9b49790844b734cf ]

    ELO devices have one Button usage in GenDesk field, which makes hid-input map
    it to BTN_LEFT; that confuses userspace, which then considers the device to be
    a mouse/touchpad instead of touchscreen.

    Fix that by unmapping BTN_LEFT and keeping only BTN_TOUCH in place.

    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/hid/hid-elo.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/drivers/hid/hid-elo.c
    +++ b/drivers/hid/hid-elo.c
    @@ -42,6 +42,12 @@ static int elo_input_configured(struct h
    {
    struct input_dev *input = hidinput->input;

    + /*
    + * ELO devices have one Button usage in GenDesk field, which makes
    + * hid-input map it to BTN_LEFT; that confuses userspace, which then
    + * considers the device to be a mouse/touchpad instead of touchscreen.
    + */
    + clear_bit(BTN_LEFT, input->keybit);
    set_bit(BTN_TOUCH, input->keybit);
    set_bit(ABS_PRESSURE, input->absbit);
    input_set_abs_params(input, ABS_PRESSURE, 0, 256, 0, 0);

    \
     
     \ /
      Last update: 2018-03-19 21:19    [W:3.419 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site