Messages in this thread | | | Date | Mon, 19 Mar 2018 21:01:51 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 11/11] block: sed-opal: check size of shadow mbr |
| |
On Mon, Mar 19, 2018 at 07:36:53PM +0100, Jonas Rabenstein wrote: > Check whether the shadow mbr does fit in the provided space on the > target. Also a proper firmware should handle this case and return an > error we may prevent problems or even damage with crappy firmwares. > > Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de> > > diff --git a/block/sed-opal.c b/block/sed-opal.c > index 51f8034edbf7..9c73bd24c55f 100644 > --- a/block/sed-opal.c > +++ b/block/sed-opal.c > @@ -1545,6 +1545,20 @@ static int write_shadow_mbr(struct opal_dev *dev, void *data) > u64 len; > int err = 0; > > + /* do we fit in the available shadow mbr space? */ > + err = generic_get_table_info(dev, OPAL_MBR, OPAL_TABLE_ROWS);
And here it gets used. So this should be merged with the previous patch.
| |