lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 026/241] perf tools: Make perf_event__synthesize_mmap_events() scale
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stephane Eranian <eranian@google.com>


    [ Upstream commit 88b897a30c525c2eee6e7f16e1e8d0f18830845e ]

    This patch significantly improves the execution time of
    perf_event__synthesize_mmap_events() when running perf record on systems
    where processes have lots of threads.

    It just happens that cat /proc/pid/maps support uses a O(N^2) algorithm to
    generate each map line in the maps file. If you have 1000 threads, then you
    have necessarily 1000 stacks. For each vma, you need to check if it
    corresponds to a thread's stack. With a large number of threads, this can take
    a very long time. I have seen latencies >> 10mn.

    As of today, perf does not use the fact that a mapping is a stack, therefore we
    can work around the issue by using /proc/pid/tasks/pid/maps. This entry does
    not try to map a vma to stack and is thus much faster with no loss of
    functonality.

    The proc-map-timeout logic is kept in case users still want some upper limit.

    In V2, we fix the file path from /proc/pid/tasks/pid/maps to actual
    /proc/pid/task/pid/maps, tasks -> task. Thanks Arnaldo for catching this.

    Committer note:

    This problem seems to have been elliminated in the kernel since commit :
    b18cb64ead40 ("fs/proc: Stop trying to report thread stacks").

    Signed-off-by: Stephane Eranian <eranian@google.com>
    Acked-by: Jiri Olsa <jolsa@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/20170315135059.GC2177@redhat.com
    Link: http://lkml.kernel.org/r/1489598233-25586-1-git-send-email-eranian@google.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/perf/util/event.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/tools/perf/util/event.c
    +++ b/tools/perf/util/event.c
    @@ -255,8 +255,8 @@ int perf_event__synthesize_mmap_events(s
    if (machine__is_default_guest(machine))
    return 0;

    - snprintf(filename, sizeof(filename), "%s/proc/%d/maps",
    - machine->root_dir, pid);
    + snprintf(filename, sizeof(filename), "%s/proc/%d/task/%d/maps",
    + machine->root_dir, pid, pid);

    fp = fopen(filename, "r");
    if (fp == NULL) {

    \
     
     \ /
      Last update: 2018-03-19 20:49    [W:2.373 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site