lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 050/241] of: fix of_device_get_modalias returned length when truncating buffers
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Rob Herring <robh@kernel.org>


    [ Upstream commit bcf54d5385abaea9c8026aae6f4eeb348671a52d ]

    If the length of the modalias is greater than the buffer size, then the
    modalias is truncated. However the untruncated length is returned which
    will cause an error. Fix this to return the truncated length. If an error
    in the case was desired, then then we should just return -ENOMEM.

    The reality is no device will ever have 4KB of compatible strings to hit
    this case.

    Signed-off-by: Rob Herring <robh@kernel.org>
    Cc: Frank Rowand <frowand.list@gmail.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/of/device.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/of/device.c
    +++ b/drivers/of/device.c
    @@ -223,7 +223,7 @@ ssize_t of_device_get_modalias(struct de
    str[i] = '_';
    }

    - return tsize;
    + return repend;
    }
    EXPORT_SYMBOL_GPL(of_device_get_modalias);


    \
     
     \ /
      Last update: 2018-03-19 20:48    [W:7.005 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site