lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 089/241] vxlan: vxlan dev should inherit lowerdevs gso_max_size
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felix Manlunas <felix.manlunas@cavium.com>


    [ Upstream commit d6acfeb17d030bb3907e77c048b0e7783ad8e5a9 ]

    vxlan dev currently ignores lowerdev's gso_max_size, which adversely
    affects TSO performance of liquidio if it's the lowerdev. Egress TCP
    packets' skb->len often exceed liquidio's advertised gso_max_size. This
    may happen on other NIC drivers.

    Fix it by assigning lowerdev's gso_max_size to that of vxlan dev. Might as
    well do likewise for gso_max_segs.

    Single flow TSO throughput of liquidio as lowerdev (using iperf3):

    Before the patch: 139 Mbps
    After the patch : 8.68 Gbps
    Percent increase: 6,144 %

    Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
    Signed-off-by: Satanand Burla <satananda.burla@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/vxlan.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/net/vxlan.c
    +++ b/drivers/net/vxlan.c
    @@ -2912,6 +2912,11 @@ static int vxlan_dev_configure(struct ne
    return -EINVAL;
    }

    + if (lowerdev) {
    + dev->gso_max_size = lowerdev->gso_max_size;
    + dev->gso_max_segs = lowerdev->gso_max_segs;
    + }
    +
    if (conf->mtu) {
    err = __vxlan_change_mtu(dev, lowerdev, dst, conf->mtu, false);
    if (err)

    \
     
     \ /
      Last update: 2018-03-19 20:41    [W:4.089 / U:0.716 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site