lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 115/241] qed: Correct MSI-x for storage
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>


    [ Upstream commit 2f78227874754b1e10cd348fd6e7693b0dabb3f6 ]

    When qedr is enabled, qed would try dividing the msi-x vectors between
    L2 and RoCE, starting with L2 and providing it with sufficient vectors
    for its queues.

    Problem is qed would also do that for storage partitions, and as those
    don't need queues it would lead qed to award those partitions with 0
    msi-x vectors, causing them to believe theye're using INTa and
    preventing them from operating.

    Fixes: 51ff17251c9c ("qed: Add support for RoCE hw init")
    Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/qlogic/qed/qed_main.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
    +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
    @@ -711,7 +711,8 @@ static int qed_slowpath_setup_int(struct
    cdev->int_params.fp_msix_cnt = cdev->int_params.out.num_vectors -
    cdev->num_hwfns;

    - if (!IS_ENABLED(CONFIG_QED_RDMA))
    + if (!IS_ENABLED(CONFIG_QED_RDMA) ||
    + QED_LEADING_HWFN(cdev)->hw_info.personality != QED_PCI_ETH_ROCE)
    return 0;

    for_each_hwfn(cdev, i)

    \
     
     \ /
      Last update: 2018-03-19 20:34    [W:4.137 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site