lkml.org 
[lkml]   [2018]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 36/41] scsi: qla2xxx: Fix smatch warning in qla25xx_delete_{rsp|req}_que
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Himanshu Madhani <himanshu.madhani@cavium.com>

    commit 62aa281470fdb7c0796d63a1cc918a8c1f02dde2 upstream.

    This patch fixes following warnings reported by smatch:

    drivers/scsi/qla2xxx/qla_mid.c:586 qla25xx_delete_req_que()
    error: we previously assumed 'req' could be null (see line 580)

    drivers/scsi/qla2xxx/qla_mid.c:602 qla25xx_delete_rsp_que()
    error: we previously assumed 'rsp' could be null (see line 596)

    Fixes: 7867b98dceb7 ("scsi: qla2xxx: Fix memory leak in dual/target mode")
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/qla2xxx/qla_mid.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/scsi/qla2xxx/qla_mid.c
    +++ b/drivers/scsi/qla2xxx/qla_mid.c
    @@ -582,8 +582,9 @@ qla25xx_delete_req_que(struct scsi_qla_h
    ret = qla25xx_init_req_que(vha, req);
    if (ret != QLA_SUCCESS)
    return QLA_FUNCTION_FAILED;
    +
    + qla25xx_free_req_que(vha, req);
    }
    - qla25xx_free_req_que(vha, req);

    return ret;
    }
    @@ -598,8 +599,9 @@ qla25xx_delete_rsp_que(struct scsi_qla_h
    ret = qla25xx_init_rsp_que(vha, rsp);
    if (ret != QLA_SUCCESS)
    return QLA_FUNCTION_FAILED;
    +
    + qla25xx_free_rsp_que(vha, rsp);
    }
    - qla25xx_free_rsp_que(vha, rsp);

    return ret;
    }

    \
     
     \ /
      Last update: 2018-03-19 19:53    [W:2.863 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site