lkml.org 
[lkml]   [2018]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] dt-bindings: mfd: bd9571mwv: Document DDR Backup Mode properties
On Wed, Mar 14, 2018 at 12:08:39PM +0100, Geert Uytterhoeven wrote:
> Document the new optional properties related to DDR Backup Mode and
> toggle/momentary power switches.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Improve property description,
> - Add properties for power switch type.
> ---
> Documentation/devicetree/bindings/mfd/bd9571mwv.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> index 9ab216a851d5619b..8804a214759845c5 100644
> --- a/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> +++ b/Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> @@ -25,6 +25,25 @@ Required properties:
> Each child node is defined using the standard
> binding for regulators.
>
> +Optional properties:
> + - rohm,ddr-backup-power : Value to use for DDR-Backup Power (default 0).
> + This is a bitmask that specifies which DDR power
> + rails need to be kept powered when backup mode is
> + entered, for system suspend:
> + - bit 0: DDR0
> + - bit 1: DDR1
> + - bit 2: DDR0C
> + - bit 3: DDR1C
> + These bits match the KEEPON_DDR* bits in the
> + documentation for the "BKUP Mode Cnt" register.
> + - rohm,rstbmode-level: The RSTB signal is configured for level mode, to
> + accommodate a toggle power switch (the RSTBMODE pin is
> + strapped low).
> + - rohm,rstbmode-pulse: The RSTB signal is configured for pulse mode, to
> + accommodate a momentary power switch (the RSTBMODE pin
> + is strapped high).
> + The two properties above are mutually exclusive.
> +
> Example:
>
> pmic: pmic@30 {
> @@ -36,6 +55,8 @@ Example:
> #interrupt-cells = <2>;
> gpio-controller;
> #gpio-cells = <2>;
> + rohm,ddr-backup-power = <15>;

Would be better to use hex for a bit mask. Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>


> + rohm,rstbmode-pulse;
>
> regulators {
> dvfs: dvfs {
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2018-03-18 13:51    [W:0.091 / U:1.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site