Messages in this thread | | | From | Kees Cook <> | Date | Sat, 17 Mar 2018 00:27:02 -0700 | Subject | Re: [PATCH v5 0/2] Remove false-positive VLAs when using max() |
| |
On Fri, Mar 16, 2018 at 12:27 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > Kees - is there some online "gcc-4.4 checker" somewhere? This does > seem to work with my gcc. I actually tested some of those files you > pointed at now.
Unfortunately my 4.4 test fails quickly:
./include/linux/jiffies.h: In function ‘jiffies_delta_to_clock_t’: ./include/linux/jiffies.h:444: error: first argument to ‘__builtin_choose_expr’ not a constant
static inline clock_t jiffies_delta_to_clock_t(long delta) { return jiffies_to_clock_t(max(0L, delta)); }
I think this is the same problem of using __builtin_constant_p() in 4.4 that we hit earlier? :(
-Kees
-- Kees Cook Pixel Security
| |